Skip to content

Conversation

@mark-inderhees
Copy link
Contributor

Some auto formatters will wrap long lines of code and insert newlines that are part of function decls outside of arguments. This change strips out all newlines so syscall typename regex function as expected.

tejlmand
tejlmand previously approved these changes Nov 11, 2024
dcpleung
dcpleung previously approved these changes Nov 11, 2024
Some auto formatters will wrap long lines of code and insert newlines
that are part of function decls outside of arguments. This change strips
out all newlines so syscall typename regex function as expected.

Signed-off-by: Mark Inderhees <[email protected]>
@mark-inderhees
Copy link
Contributor Author

Pushed an update to handle a few more weird format cases and always handle all formatting issues inside typename_split

@mark-inderhees
Copy link
Contributor Author

mark-inderhees commented Nov 13, 2024

The build checks failed. Windows builds failed on toolchain install

Installing 'nios2-zephyr-elf' toolchain ...
ERROR: Toolchain download failed

This failure seems unrelated to this pull request. How can I rerun the job?

@nashif nashif merged commit 1993ea0 into zephyrproject-rtos:main Nov 16, 2024
32 checks passed
@github-actions
Copy link

Hi @mark-inderhees!
Congratulations on getting your very first Zephyr pull request merged 🎉🥳. This is a fantastic achievement, and we're thrilled to have you as part of our community!

To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge.

Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁

@mark-inderhees mark-inderhees deleted the syscall branch October 1, 2025 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: Build System area: Userspace Userspace size: XS A PR changing only a single line of code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants